legacy: Arduino preprocess subroutine refactorization (part 3) #2193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last piece in RunCTags:
parser := &ctags.CTagsParser{}
parser.Parse(ctagsStdout, sketch.MainFile)
parser.FixCLinkageTagsDeclarations()
prototypes, line := parser.GeneratePrototypes()
if line != -1 {
prototypesLineWhereToInsert = line
}
has been moved at the beginning of PrototypesAdder.
RunCTags now returns the output of ctags instead of `prototypes` and `line`.
This also allows to remove the context variables that keeps those
information.
cmaglie
changed the title
cmaglie
added
type: enhancement
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2193 +/- ##
==========================================
- Coverage 62.79% 62.78% -0.01%
==========================================
Files 221 221
Lines 19463 19465 +2
==========================================
+ Hits 12221 12222 +1
+ Misses 6155 6154 -1
- Partials 1087 1089 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
alessio-perugini
approved these changes
May 31, 2023
11 tasks
cmaglie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
This PR is a try to split the bigger PR #2147 into smaller pieces to allow an easier review process.
What is the current behavior?
No changes
Does this PR introduce a breaking change, and is titled accordingly?
No
Other information